Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new prerequisite to the release checklist #2419

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Add a new prerequisite to the release checklist #2419

merged 1 commit into from
Jan 19, 2022
+1 −0

Conversation

roberthbailey
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: c883f729-4c73-4394-aec6-0913bbf1052e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@google-oss-prow google-oss-prow bot added the lgtm label Jan 7, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-prow google-oss-prow bot removed the lgtm label Jan 7, 2022
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 45b0a8fd-7b2e-4983-8369-cc62836c3b26

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey roberthbailey force-pushed the app-engine-publish-prerequisite branch from a7e3689 to fdfb068 Compare January 9, 2022 09:01
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 5cfb1e2d-cd91-4e5b-953b-bf58aa305736

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 8caeff4f-86e5-419a-9372-2c08531f71c1

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey
Copy link
Member Author

e2e-feature-gates:

--- FAIL: TestAutoscalerWebhook (313.18s)
    framework.go:284: 
        	Error Trace:	framework.go:284
        	            				fleetautoscaler_test.go:479
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestAutoscalerWebhook
        	Messages:   	error waiting for fleet condition on fleet: simple-fleet-7276q
FAIL
time="2022-01-11 22:08:44.620" level=info msg="Namespace 1641938425 is deleted"
FAIL	agones.dev/agones/test/e2e	499.841s
FAIL

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: b39356b8-b67a-45f8-8087-01c23975b6fa

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey roberthbailey force-pushed the app-engine-publish-prerequisite branch from fdfb068 to fcc96a2 Compare January 12, 2022 17:31
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 98eedcae-e1d6-42a6-8878-b00071bb4a39

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey roberthbailey added feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) kind/cleanup Refactoring code, fixing up documentation, etc labels Jan 14, 2022
@SaitejaTamma SaitejaTamma removed the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Jan 18, 2022
@roberthbailey roberthbailey force-pushed the app-engine-publish-prerequisite branch from fcc96a2 to 528e4a8 Compare January 19, 2022 02:39
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a95fcf4d-54d0-47f0-92af-9e4f58a657fc

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2419/head:pr_2419 && git checkout pr_2419
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.21.0-528e4a8

@roberthbailey roberthbailey merged commit fa98bfc into googleforgames:main Jan 19, 2022
@SaitejaTamma SaitejaTamma added this to the 1.21.0 milestone Feb 8, 2022
@roberthbailey roberthbailey deleted the app-engine-publish-prerequisite branch March 28, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp

Assignees

@markmandel markmandel

Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc size/XS
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@roberthbailey @agones-bot @markmandel @SaitejaTamma